diff ChangeLog @ 279:49b452b667a6 noffle

[svn] * src/util.c: localTimeDiff() cached its value and recalculated it every hour of clock time, regardless of the time the calculated was based on. This is potentially dangerous at daylight saving changes. So instead use the cached last result only when the new request is to be based on a time in the same hour as the cached result. * src/util.c: Replace the alternate Utl_mktimeGMT() implementation used when timegm() is not available. The previous version, as suggested by the glibc timegm() man page, used setenv() and unsetenv() for changing the environment. These aren't POSIX function, and the POSIX putenv() (a) is tricky to manage if the same var is being constantly update and memory isn't to leak, and (b) provides no way to remove an environment entry. So change to an implementation Wget uses. This should compile on not glibc systems - the previous version failed to build on Solaris.
author bears
date Sun, 17 Nov 2002 15:18:19 +0000
parents 1fdde6512033
children 9c54bf672ca1
line wrap: on
line diff
--- a/ChangeLog	Sun Nov 10 18:49:41 2002 +0000
+++ b/ChangeLog	Sun Nov 17 15:18:19 2002 +0000
@@ -1,3 +1,19 @@
+Sun Nov 17 2002 Jim Hague <jim.hague@acm.org>
+
+* src/util.c: localTimeDiff() cached its value and recalculated it every
+  hour of clock time, regardless of the time the calculated was based on.
+  This is potentially dangerous at daylight saving changes. So instead
+  use the cached last result only when the new request is to be based on
+  a time in the same hour as the cached result.
+* src/util.c: Replace the alternate Utl_mktimeGMT() implementation used when
+  timegm() is not available. The previous version, as suggested by the
+  glibc timegm() man page, used setenv() and unsetenv() for changing the
+  environment. These aren't POSIX function, and the POSIX putenv()
+  (a) is tricky to manage if the same var is being constantly update and
+  memory isn't to leak, and (b) provides no way to remove an environment
+  entry. So change to an implementation Wget uses. This should compile on
+  not glibc systems - the previous version failed to build on Solaris.
+	
 Sun Nov 10 2002 Jim Hague <jim.hague@acm.org>
 
 * src/client.c,src/fetch.c,src/lock.c.src/protocol.c,src/util.h,src/util.c: