Mercurial > noffle

diff src/client.c @ 240:fbff73fe5b40 noffle

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
[svn] * src/client.c: That wasn't a memory leak fixed on Feb 8th. That was a cockup cause by my forgetting that Cont_app takes ownership of an overview. Revert it and add comment to Cont_app. Spotted with the aid of valgrind. * src/post.c,src/pseudo.c * src/util.c: Fix out of bounds write bug spotted by valgrind. * src/database.c: Fix minor memory leak spotted by valgrind. Valgrind is at http://devel-home.kde.org/~sewardj/.
author bears
date Tue, 26 Feb 2002 17:13:31 +0000
parents 91c91d102564
children 93d5d8b098da
line wrap: on
line diff
--- a/src/client.c	Thu Feb 14 17:17:02 2002 +0000
+++ b/src/client.c	Tue Feb 26 17:13:31 2002 +0000
@@ -1,7 +1,7 @@
 /*
   client.c
 
-  $Id: client.c 364 2002-02-08 17:06:25Z bears $
+  $Id: client.c 371 2002-02-26 17:13:31Z bears $
 */
 
 #if HAVE_CONFIG_H
@@ -1026,7 +1026,7 @@
                 del_Over( ov );
 		continue;
             }
-            Cont_app( ov );
+            Cont_app( ov );     /* Cont modules owns ov after this */
             prepareEntry( ov );
             if ( action == FILTER_FULL
 		 || ( action == FILTER_THREAD && needsMark( ref ) ) )
@@ -1034,7 +1034,6 @@
                 Req_add( client.serv, msgId );
                 ++cntMarked;
             }
-            del_Over( ov );
         }
         Grp_setRmtNext( client.grp, rmtNumb + 1 );
     }