# HG changeset patch # User bears # Date 1016189396 0 # Node ID 6eb6c912a0e40fb040cb851fefafe1ac1e86d168 # Parent aa9e65f63755bf1fcdbb64fac8c3c4eddf48dd89 [svn] * src/group.c: Make comparison against NULL explicit in an if containing an assignment, as I'm sad enough to think it is safer if it is obvious that the assignment is meant to be there. diff -r aa9e65f63755 -r 6eb6c912a0e4 src/group.c --- a/src/group.c Wed Mar 13 11:12:54 2002 +0000 +++ b/src/group.c Fri Mar 15 10:49:56 2002 +0000 @@ -7,7 +7,7 @@ loadGrp() and saveGrp(). This is done transparently. Access to the groups database is done by group name, by the functions defined in group.h. - $Id: group.c 358 2001-12-18 15:27:08Z mirkol $ + $Id: group.c 374 2002-03-15 10:49:56Z bears $ */ #if HAVE_CONFIG_H @@ -434,7 +434,7 @@ /* Find "all", "all.*", "*.all" or "*.all.*" */ pname = name; - while ( ppat = strstr( pname, "all" ) ) + while ( ( ppat = strstr( pname, "all" ) ) != NULL ) { if ( ( ppat == name || *(ppat - 1) == '.' ) && ( *(ppat+4) == '\0' || *(ppat+4) == '.' ) )