changeset 390:2ad4c1c97734 noffle

[svn] * src/client.c: Return correct status from Client_postArt() and add function comment detailing what return code should be, because it's not obvious that the return code should report success when the posting failed for reasons other than connection problems. This should fix problem with failing posting stopping fetches. Thanks to Dan Jacobson for spotting this. * src/client.c: Fix problemette with filter discards not updating remote group article count and so the overview being refetched until and article appears that doesn't fall foul of the filter and thus does update the remove group 'next article' marker. Thanks to Dan Jacobson for spotting this. * src/content.c: Don't be fooled into thinking a filename starting ".." is just "..". * src/outgoing.c: Don't assume "." and ".." are the first files returned from readdir(). Thanks to Andreas Happe for spotting this. * src/noffle.c: Update online help to include 'm' group posting status. * src/server.c: Move incorrect updating of server.grp in doGrp() which was causing doGrp() to not retrieve remote article details when in online mode. Thanks to Miernik and Andreas Happe for reporting the problem.
author bears
date Thu, 22 May 2003 10:04:38 +0100
parents f81fdcc2696b
children 6cb66f5a0479
files ChangeLog src/noffle.c
diffstat 2 files changed, 25 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Thu May 22 09:41:37 2003 +0100
+++ b/ChangeLog	Thu May 22 10:04:38 2003 +0100
@@ -1,3 +1,26 @@
+
+Thu May 22 2003 Jim Hague <jim.hague@acm.org>
+
+* src/client.c: Return correct status from Client_postArt() and add
+  function comment detailing what return code should be, because it's
+  not obvious that the return code should report success when the
+  posting failed for reasons other than connection problems. This should fix
+  problem with failing posting stopping fetches. Thanks to Dan Jacobson
+  for spotting this.
+* src/client.c: Fix problemette with filter discards not updating remote
+  group article count and so the overview being refetched until
+  and article appears that doesn't fall foul of the filter and thus does
+  update the remove group 'next article' marker. Thanks to Dan Jacobson
+  for spotting this.
+* src/content.c: Don't be fooled into thinking a filename starting ".."
+  is just "..".
+* src/outgoing.c: Don't assume "." and ".." are the first files returned
+  from readdir(). Thanks to Andreas Happe for spotting this.
+* src/noffle.c: Update online help to include 'm' group posting status.
+* src/server.c: Move incorrect updating of server.grp in doGrp() which was
+  causing doGrp() to not retrieve remote article details when in online
+  mode. Thanks to Miernik and Andreas Happe for reporting the problem.
+
 Thu Apr 03 2003 Jim Hague <jim.hague@acm.org>
 
 * src/common.h,src/control.c,src/noffle.c,src/post.c: Find actual bug
--- a/src/noffle.c	Thu May 22 09:41:37 2003 +0100
+++ b/src/noffle.c	Thu May 22 10:04:38 2003 +0100
@@ -10,7 +10,7 @@
   received for some seconds (to allow multiple clients connect at the same
   time).
 
-  $Id: noffle.c 517 2003-04-03 17:21:24Z bears $
+  $Id: noffle.c 532 2003-05-22 09:04:38Z bears $
 */
 
 #if HAVE_CONFIG_H
@@ -567,7 +567,7 @@
       " -h | --help                      Show this text\n"
       " -l | --list                      List groups on fetch list\n"
       " -m | --modify desc <grp> <desc>  Modify a group description\n"
-      " -m | --modify post <grp> (y|n)   Modify posting status of a local group\n"
+      " -m | --modify post <grp> (y|m|n) Modify posting status of a local group\n"
       " -n | --online                    Switch to online mode\n"
       " -o | --offline                   Switch to offline mode\n"
       " -O | --outgoing [server]         List articles queued for posting\n"